Some checks failed
CI/CD Pipeline / Backend Tests (push) Has been cancelled
CI/CD Pipeline / Frontend Tests (push) Has been cancelled
CI/CD Pipeline / Build Docker Images (push) Has been cancelled
CI/CD Pipeline / Security Scan (push) Has been cancelled
CI/CD Pipeline / Deploy to Staging (push) Has been cancelled
CI/CD Pipeline / Deploy to Production (push) Has been cancelled
## Overview
Complete architectural overhaul merging dual event systems into a unified activity model
with multi-VIP support, enhanced search capabilities, and improved UX throughout.
## Database & Schema Changes
### Unified Activity Model (Breaking Change)
- Merged Event/EventTemplate/EventAttendance into single ScheduleEvent model
- Dropped duplicate tables: Event, EventAttendance, EventTemplate
- Single source of truth for all activities (transport, meals, meetings, events)
- Migration: 20260131180000_drop_duplicate_event_tables
### Multi-VIP Support (Breaking Change)
- Changed schema from single vipId to vipIds array (String[])
- Enables multiple VIPs per activity (ridesharing, group events)
- Migration: 20260131122613_multi_vip_support
- Updated all backend services to handle multi-VIP queries
### Seed Data Updates
- Rebuilt seed.ts with unified activity model
- Added multi-VIP rideshare examples (3 VIPs in SUV, 4 VIPs in van)
- Includes mix of transport + non-transport activities
- Balanced VIP test data (50% OFFICE_OF_DEVELOPMENT, 50% ADMIN)
## Backend Changes
### Services Cleanup
- Removed deprecated common-events endpoints
- Updated EventsService for multi-VIP support
- Enhanced VipsService with multi-VIP activity queries
- Updated DriversService, VehiclesService for unified model
- Added add-vips-to-event.dto for bulk VIP assignment
### Abilities & Permissions
- Updated ability.factory.ts: Event → ScheduleEvent subject
- Enhanced guards for unified activity permissions
- Maintained RBAC (Administrator, Coordinator, Driver roles)
### DTOs
- Updated create-event.dto: vipId → vipIds array
- Updated update-event.dto: vipId → vipIds array
- Added add-vips-to-event.dto for bulk operations
- Removed obsolete event-template DTOs
## Frontend Changes
### UI/UX Improvements
**Renamed "Schedule" → "Activities" Throughout**
- More intuitive terminology for coordinators
- Updated navigation, page titles, buttons
- Changed "Schedule Events" to "Activities" in Admin Tools
**Activities Page Enhancements**
- Added comprehensive search bar (searches: title, location, description, VIP names, driver, vehicle)
- Added sortable columns: Title, Type, VIPs, Start Time, Status
- Visual sort indicators (↑↓ arrows)
- Real-time result count when searching
- Empty state with helpful messaging
**Admin Tools Updates**
- Balanced VIP test data: 10 OFFICE_OF_DEVELOPMENT + 10 ADMIN
- More BSA-relevant organizations (Coca-Cola, AT&T, Walmart vs generic orgs)
- BSA leadership titles (National President, Chief Scout Executive, Regional Directors)
- Relabeled "Schedule Events" → "Activities"
### Component Updates
**EventList.tsx (Activities Page)**
- Added search state management with real-time filtering
- Implemented multi-field sorting with direction toggle
- Enhanced empty states for search + no data scenarios
- Filter tabs + search work together seamlessly
**VIPSchedule.tsx**
- Updated for multi-VIP schema (vipIds array)
- Shows complete itinerary timeline per VIP
- Displays all activities for selected VIP
- Groups by day with formatted dates
**EventForm.tsx**
- Updated to handle vipIds array instead of single vipId
- Multi-select VIP assignment
- Maintains backward compatibility
**AdminTools.tsx**
- New balanced VIP test data (10/10 split)
- BSA-context organizations
- Updated button labels ("Add Test Activities")
### Routing & Navigation
- Removed /common-events routes
- Updated navigation menu labels
- Maintained protected route structure
- Cleaner URL structure
## New Features
### Multi-VIP Activity Support
- Activities can have multiple VIPs (ridesharing, group events)
- Efficient seat utilization tracking (3/6 seats, 4/12 seats)
- Better coordination for shared transport
### Advanced Search & Filtering
- Full-text search across multiple fields
- Instant filtering as you type
- Search + type filters work together
- Clear visual feedback (result counts)
### Sortable Data Tables
- Click column headers to sort
- Toggle ascending/descending
- Visual indicators for active sort
- Sorts persist with search/filter
### Enhanced Admin Tools
- One-click test data generation
- Realistic BSA Jamboree scenario data
- Balanced department representation
- Complete 3-day itineraries per VIP
## Testing & Validation
### Playwright E2E Tests
- Added e2e/ directory structure
- playwright.config.ts configured
- PLAYWRIGHT_GUIDE.md documentation
- Ready for comprehensive E2E testing
### Manual Testing Performed
- Multi-VIP activity creation ✓
- Search across all fields ✓
- Column sorting (all fields) ✓
- Filter tabs + search combination ✓
- Admin Tools data generation ✓
- Database migrations ✓
## Breaking Changes & Migration
**Database Schema Changes**
1. Run migrations: `npx prisma migrate deploy`
2. Reseed database: `npx prisma db seed`
3. Existing data incompatible (dev environment - safe to nuke)
**API Changes**
- POST /events now requires vipIds array (not vipId string)
- GET /events returns vipIds array
- GET /vips/:id/schedule updated for multi-VIP
- Removed /common-events/* endpoints
**Frontend Type Changes**
- ScheduleEvent.vipIds: string[] (was vipId: string)
- EventFormData updated accordingly
- All pages handle array-based VIP assignment
## File Changes Summary
**Added:**
- backend/prisma/migrations/20260131180000_drop_duplicate_event_tables/
- backend/src/events/dto/add-vips-to-event.dto.ts
- frontend/src/components/InlineDriverSelector.tsx
- frontend/e2e/ (Playwright test structure)
- Documentation: NAVIGATION_UX_IMPROVEMENTS.md, PLAYWRIGHT_GUIDE.md
**Modified:**
- 30+ backend files (schema, services, DTOs, abilities)
- 20+ frontend files (pages, components, types)
- Admin tools, seed data, navigation
**Removed:**
- Event/EventAttendance/EventTemplate database tables
- Common events frontend pages
- Obsolete event template DTOs
## Next Steps
**Pending (Phase 3):**
- Activity Templates for bulk event creation
- Operations Dashboard (today's activities + conflicts)
- Complete workflow testing with real users
- Additional E2E test coverage
## Notes
- Development environment - no production data affected
- Database can be reset anytime: `npx prisma migrate reset`
- All servers tested and running successfully
- HMR working correctly for frontend changes
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
304 lines
7.2 KiB
Markdown
304 lines
7.2 KiB
Markdown
# Playwright E2E Testing Guide
|
|
|
|
## Overview
|
|
|
|
Playwright is now set up for end-to-end testing. This allows both developers and Claude AI to run browser tests and see complete output including console logs, network requests, and errors.
|
|
|
|
## Why Playwright?
|
|
|
|
**For Developers:**
|
|
- Automated testing prevents regressions
|
|
- Catches bugs before they reach production
|
|
- Tests serve as documentation for how features should work
|
|
|
|
**For Claude AI:**
|
|
- Can see browser console output without manual copy/paste
|
|
- Can see network requests/responses
|
|
- Can run tests to verify changes work
|
|
- Screenshots and videos on test failures
|
|
|
|
## Running Tests
|
|
|
|
### Basic Commands
|
|
|
|
```bash
|
|
# Run all tests (headless)
|
|
npm test
|
|
|
|
# Run tests with browser visible
|
|
npm run test:headed
|
|
|
|
# Run tests in debug mode (step through tests)
|
|
npm run test:debug
|
|
|
|
# Open Playwright UI (interactive test runner)
|
|
npm run test:ui
|
|
|
|
# Show test report
|
|
npm run test:report
|
|
```
|
|
|
|
### Running Specific Tests
|
|
|
|
```bash
|
|
# Run a specific test file
|
|
npx playwright test navigation.spec.ts
|
|
|
|
# Run tests matching a pattern
|
|
npx playwright test --grep "login"
|
|
|
|
# Run a specific test by line number
|
|
npx playwright test navigation.spec.ts:15
|
|
```
|
|
|
|
## Test Structure
|
|
|
|
### Test Files Location
|
|
|
|
All tests are in `frontend/e2e/`:
|
|
|
|
- `navigation.spec.ts` - Tests routing and navigation
|
|
- `api.spec.ts` - Tests API calls and network requests
|
|
- `accessibility.spec.ts` - Tests accessibility with axe-core
|
|
- `auth.setup.ts` - Authentication helpers
|
|
|
|
### Example Test
|
|
|
|
```typescript
|
|
import { test, expect } from '@playwright/test';
|
|
|
|
test('example test', async ({ page }) => {
|
|
// Listen to console logs
|
|
page.on('console', (msg) => {
|
|
console.log(`[BROWSER ${msg.type()}]:`, msg.text());
|
|
});
|
|
|
|
// Listen to errors
|
|
page.on('pageerror', (error) => {
|
|
console.error('[BROWSER ERROR]:', error.message);
|
|
});
|
|
|
|
// Navigate and test
|
|
await page.goto('/login');
|
|
await expect(page.locator('text=VIP Coordinator')).toBeVisible();
|
|
});
|
|
```
|
|
|
|
## What Claude Can See
|
|
|
|
When Claude runs Playwright tests, Claude can see:
|
|
|
|
1. **Browser Console Logs**
|
|
```
|
|
[BROWSER log]: User logged in
|
|
[BROWSER error]: Cannot read property 'map' of undefined
|
|
[BROWSER warn]: Deprecated API usage
|
|
```
|
|
|
|
2. **Network Requests**
|
|
```
|
|
[→ REQUEST] GET http://localhost:3000/api/v1/users
|
|
[← RESPONSE] 200 GET http://localhost:3000/api/v1/users
|
|
[RESPONSE BODY] {"users": [...]}
|
|
```
|
|
|
|
3. **Page Errors**
|
|
```
|
|
[PAGE ERROR]: TypeError: Cannot read property 'map' of undefined
|
|
at VIPPage.tsx:45
|
|
```
|
|
|
|
4. **Screenshots** (on failure)
|
|
- Saved to `test-results/`
|
|
|
|
5. **Videos** (on failure)
|
|
- Saved to `test-results/`
|
|
|
|
6. **Traces** (on retry)
|
|
- Full timeline of what happened
|
|
- View with `npx playwright show-trace trace.zip`
|
|
|
|
## Writing New Tests
|
|
|
|
### Test Template
|
|
|
|
Create a new file in `e2e/` directory:
|
|
|
|
```typescript
|
|
import { test, expect } from '@playwright/test';
|
|
|
|
test.describe('Feature Name', () => {
|
|
test('should do something', async ({ page }) => {
|
|
// Enable logging
|
|
page.on('console', (msg) => console.log(`[BROWSER]:`, msg.text()));
|
|
page.on('pageerror', (error) => console.error('[ERROR]:', error.message));
|
|
|
|
// Your test code
|
|
await page.goto('/your-page');
|
|
await expect(page.locator('selector')).toBeVisible();
|
|
});
|
|
});
|
|
```
|
|
|
|
### Best Practices
|
|
|
|
1. **Always add console listeners** - This helps Claude debug issues
|
|
```typescript
|
|
page.on('console', (msg) => console.log(`[BROWSER]:`, msg.text()));
|
|
page.on('pageerror', (error) => console.error('[ERROR]:', error));
|
|
```
|
|
|
|
2. **Add network listeners for API tests**
|
|
```typescript
|
|
page.on('request', (req) => console.log(`[→] ${req.method()} ${req.url()}`));
|
|
page.on('response', (res) => console.log(`[←] ${res.status()} ${res.url()}`));
|
|
```
|
|
|
|
3. **Use descriptive test names**
|
|
```typescript
|
|
test('should show error message when login fails', async ({ page }) => {
|
|
// ...
|
|
});
|
|
```
|
|
|
|
4. **Wait for network to be idle**
|
|
```typescript
|
|
await page.goto('/dashboard');
|
|
await page.waitForLoadState('networkidle');
|
|
```
|
|
|
|
5. **Test user workflows, not implementation**
|
|
```typescript
|
|
// Good
|
|
await page.click('text=Add VIP');
|
|
await page.fill('input[name="name"]', 'John Doe');
|
|
await page.click('button:has-text("Save")');
|
|
|
|
// Bad (too implementation-specific)
|
|
await page.locator('#vip-form > div > button.submit').click();
|
|
```
|
|
|
|
## Common Issues
|
|
|
|
### Tests Fail to Start
|
|
|
|
**Problem:** `Error: No tests found`
|
|
**Solution:** Make sure test files end with `.spec.ts` or `.test.ts`
|
|
|
|
### Can't Connect to Dev Server
|
|
|
|
**Problem:** `Error: connect ECONNREFUSED`
|
|
**Solution:** The dev server should start automatically. If not, check `playwright.config.ts` webServer config
|
|
|
|
### Auth0 Login Required
|
|
|
|
**Problem:** Tests need to log in through Auth0
|
|
**Solution:** For now, tests can mock authentication. See `auth.setup.ts` for details.
|
|
|
|
## Configuration
|
|
|
|
All configuration is in `playwright.config.ts`:
|
|
|
|
```typescript
|
|
export default defineConfig({
|
|
testDir: './e2e', // Where tests live
|
|
timeout: 30 * 1000, // Test timeout
|
|
use: {
|
|
baseURL: 'http://localhost:5173',
|
|
trace: 'on-first-retry', // Capture trace on failure
|
|
screenshot: 'only-on-failure',
|
|
video: 'retain-on-failure',
|
|
},
|
|
webServer: {
|
|
command: 'npm run dev', // Start dev server automatically
|
|
url: 'http://localhost:5173',
|
|
reuseExistingServer: true,
|
|
},
|
|
});
|
|
```
|
|
|
|
## Debugging Tests
|
|
|
|
### Method 1: Headed Mode
|
|
|
|
See the browser as tests run:
|
|
```bash
|
|
npm run test:headed
|
|
```
|
|
|
|
### Method 2: Debug Mode
|
|
|
|
Step through tests line by line:
|
|
```bash
|
|
npm run test:debug
|
|
```
|
|
|
|
### Method 3: UI Mode (Best for Development)
|
|
|
|
Interactive test runner with time travel debugging:
|
|
```bash
|
|
npm run test:ui
|
|
```
|
|
|
|
### Method 4: Console Logs
|
|
|
|
Add console.log in your test:
|
|
```typescript
|
|
test('debug test', async ({ page }) => {
|
|
console.log('Starting test...');
|
|
await page.goto('/login');
|
|
console.log('Navigated to login');
|
|
|
|
const title = await page.title();
|
|
console.log('Page title:', title);
|
|
});
|
|
```
|
|
|
|
## CI/CD Integration
|
|
|
|
Tests can run in continuous integration:
|
|
|
|
```yaml
|
|
# .github/workflows/test.yml
|
|
- name: Install dependencies
|
|
run: npm ci
|
|
- name: Install Playwright Browsers
|
|
run: npx playwright install --with-deps
|
|
- name: Run Playwright tests
|
|
run: npm test
|
|
- name: Upload test results
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: playwright-report
|
|
path: playwright-report/
|
|
```
|
|
|
|
## Tips for Claude
|
|
|
|
When Claude runs tests, look for:
|
|
|
|
1. **Console errors** - Any red [BROWSER error] or [PAGE ERROR] messages
|
|
2. **Failed network requests** - 400, 500 status codes
|
|
3. **Test failures** - Which assertions failed and why
|
|
4. **Screenshots** - Visual evidence of what went wrong
|
|
5. **Traces** - Timeline of events leading to failure
|
|
|
|
## Resources
|
|
|
|
- [Playwright Documentation](https://playwright.dev)
|
|
- [Best Practices](https://playwright.dev/docs/best-practices)
|
|
- [API Reference](https://playwright.dev/docs/api/class-playwright)
|
|
- [Debugging Guide](https://playwright.dev/docs/debug)
|
|
|
|
## Next Steps
|
|
|
|
1. Add more tests for critical user flows
|
|
2. Set up CI/CD to run tests automatically
|
|
3. Add visual regression testing
|
|
4. Add performance testing with Lighthouse
|
|
|
|
---
|
|
|
|
**Last Updated:** 2026-01-31
|
|
**Playwright Version:** 1.58.1
|