kyle/vip-coordinator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: improve first-user auto-approve logic

Browse Source 
- Remove hardcoded test@test.com auto-approval
- Count approved users instead of total users
- Only first user gets auto-approved as ADMINISTRATOR
- Subsequent users default to DRIVER role and require approval

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
kyle
2026-01-31 20:07:30 +01:00
parent b8fac5de23
commit 689b89ea83
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
backend/src/auth/auth.service.ts
View File

@@ -26,25 +26,26 @@ export class AuthService {
if (!user) { if (!user) {
// Check if this is the first user (auto-approve as admin) // Check if this is the first user (auto-approve as admin)
const userCount = await this.prisma.user.count(); const approvedUserCount = await this.prisma.user.count({
const isFirstUser = userCount === 0; where: { isApproved: true, deletedAt: null },
});
// Auto-approve test users for Playwright tests const isFirstUser = approvedUserCount === 0;
const isTestUser = email === 'test@test.com';
this.logger.log( this.logger.log(
`Creating new user: ${email} (isFirstUser: ${isFirstUser}, isTestUser: ${isTestUser})`, `Creating new user: ${email} (approvedUserCount: ${approvedUserCount}, isFirstUser: ${isFirstUser})`,
); );
// Create new user // Create new user
// First user is auto-approved as ADMINISTRATOR
// Subsequent users default to DRIVER and require approval
user = await this.prisma.user.create({ user = await this.prisma.user.create({
data: { data: {
auth0Id, auth0Id,
email, email,
name, name,
picture, picture,
role: isFirstUser || isTestUser ? Role.ADMINISTRATOR : Role.DRIVER, role: isFirstUser ? Role.ADMINISTRATOR : Role.DRIVER,
isApproved: isFirstUser || isTestUser, // Auto-approve first user and test users isApproved: isFirstUser, // Auto-approve first user only
}, },
include: { driver: true }, include: { driver: true },
}); });