kyle/SignageHTML
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove hardcoded API key from WeatherManager.js #2

New Issue
Closed
opened 2026-02-15 04:56:14 -08:00 by kyle · 0 comments
kyle commented 2026-02-15 04:56:14 -08:00
Owner
Copy Link

Problem: OpenWeatherMap API key was hardcoded as a fallback in WeatherManager.js, posing a security risk if the code is shared or pushed to a public repo.

Solution: Removed the hardcoded fallback key. Added a visible warning UI when no API key is configured, guiding the user to set it via file. Falls back to calculated sun times if weather API is unavailable.

Files changed:

**Problem:** OpenWeatherMap API key was hardcoded as a fallback in WeatherManager.js, posing a security risk if the code is shared or pushed to a public repo. **Solution:** Removed the hardcoded fallback key. Added a visible warning UI when no API key is configured, guiding the user to set it via file. Falls back to calculated sun times if weather API is unavailable. **Files changed:** -
kyle closed this issue 2026-02-15 05:05:25 -08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kyle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kyle/SignageHTML#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?