kyle/SignageHTML
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move ConfigManager modal HTML to template element #12

New Issue
Closed
opened 2026-02-15 05:31:35 -08:00 by kyle · 0 comments
kyle commented 2026-02-15 05:31:35 -08:00
Owner
Copy Link

Problem: ConfigManager.createConfigModal() contained a 100-line HTML template literal with interpolated config values, making it hard to read, debug, and maintain.

Solution: Moved the static modal HTML to a template element in index.html. ConfigManager now clones the template and populates dynamic values (orientation, dark mode, background settings, sites) programmatically after cloning.

Files changed:

  • index.html - Added template id=config-modal-template
  • public/js/components/ConfigManager.js - Clone template instead of innerHTML
Problem: ConfigManager.createConfigModal() contained a 100-line HTML template literal with interpolated config values, making it hard to read, debug, and maintain. Solution: Moved the static modal HTML to a template element in index.html. ConfigManager now clones the template and populates dynamic values (orientation, dark mode, background settings, sites) programmatically after cloning. Files changed: - index.html - Added template id=config-modal-template - public/js/components/ConfigManager.js - Clone template instead of innerHTML
kyle closed this issue 2026-02-15 05:32:06 -08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kyle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kyle/SignageHTML#12
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?